Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't convert .mjs config path to url twice on Windows #1113

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Apr 3, 2025

Summary

Closes #1107

Test plan

  • - tester-app on Windows with .mjs config works

Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 129be0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/repack Patch
@callstack/repack-plugin-expo-modules Patch
@callstack/repack-plugin-nativewind Patch
@callstack/repack-plugin-reanimated Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 1:51pm

@jbroma jbroma merged commit 4fe3b04 into main Apr 3, 2025
5 checks passed
@jbroma jbroma deleted the fix/load-project-config-windows branch April 3, 2025 15:29
jbroma added a commit that referenced this pull request Apr 3, 2025
* fix: dont convert to file url again for mjs configs on windows

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest commit to loadProjectConfig.js causes windows config file name to be converted to a url twice
1 participant