Skip to content

feat: Update tester-expo app and cover it with e2e tests - #1519

Open
MrMuzyk wants to merge 34 commits into
callstack:mainfrom
MrMuzyk:tester-expo-app-e2e
Open

MrMuzyk wants to merge 34 commits into
callstack:mainfrom
MrMuzyk:tester-expo-app-e2e

Merge remote-tracking branch 'origin/main' into tester-expo-app-e2e

46a6035
Select commit
Loading
Failed to load commit list.
apex-sentinel-staging / Apex Sentinel succeeded Nov 16, 2026 in 7m 41s

2 finding(s) · approve

Apex Sentinel · ✅ Approve

2 finding(s): 2 minor.

🟡 Minor (2)

Where Finding
apps/tester-expo/app/symbolication.tsx:10 Failed symbolication leaves the button reading "Symbolicated" and disabled
.github/workflows/e2e-expo.yml:200 e2e-expo iOS job boots a simulator before prebuild; simctl create can die on a stale e2e device
Not in the reviewers' prompt (1 file)
  • pnpm-lock.yaml: generated or a lockfile, so its lines were left out

3 findings below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (6e72ac0df314).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

Annotations

Check warning on line 23 in apps/tester-expo/app/symbolication.tsx

See this annotation in the file changed.

@apex-sentinel-staging apex-sentinel-staging / Apex Sentinel

minor: Failed symbolication leaves the button reading "Symbolicated" and disabled

When `symbolicateStackTrace` rejects, the screen reports `frame: failed: <message>` but the button still reads "Symbolicated" and is disabled — no retry, and the state claims success. `frame` is a single string holding either a symbolicated frame or an error message, and `app/symbolication.tsx` derives both the label and `disabled` from `frame !== undefined`.

Check warning on line 218 in .github/workflows/e2e-expo.yml

See this annotation in the file changed.

@apex-sentinel-staging apex-sentinel-staging / Apex Sentinel

minor: e2e-expo iOS job boots a simulator before prebuild; simctl create can die on a stale e2e device

`xcrun simctl create e2e` exits 1 with "device already exists" on any re-run or stateful macOS runner where the `e2e` device persists in `~/Library/Developer/CoreSimulator/Devices` from a prior boot. `simctl create` is not idempotent, so the step kills the job before any test runs.