Repository navigation
Conversation
A script is cached under `<caller>_<scriptId>`, and the native side uses the same id as the file name. A new version of a script therefore replaces the previous one on the device. An optional `cacheKey` on the locator is appended to the `uniqueId` (`<caller>_<scriptId>@<cacheKey>`), so each key gets its own cache entry and its own file. Without `cacheKey`, nothing changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@Fl0p is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 854ede5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1529.
ScriptManagercaches a script under<caller>_<scriptId>, and the native side uses the same id as the file name (RemoteScriptLoader.getScriptFilePathon Android,ScriptManager.mmon iOS). A new version of a script therefore replaces the previous one on the device, and an app cannot keep the previous version to load it again when the new one fails.This PR adds an optional
cacheKeytoScriptLocator. When it is set,Script.fromappends it to theuniqueId(<caller>_<scriptId>@<cacheKey>), so each key gets its own cache entry and its own file. WithoutcacheKey, nothing changes.ScriptLocator.cacheKeywith its docs (types.ts)Script.frombuilds theuniqueIdwith the key (Script.ts)loadScript/prefetchScriptstill uses the base id, so one script id loads once at a timeinvalidateScriptsalready works with the cache ids, so passing<caller>_<scriptId>@<cacheKey>removes one cached copyScriptManagerdocs and aminorchangesetNo native change: both platforms already take the file name from
uniqueId.Test plan
should append cacheKey to uniqueId: the resolved locator hasmain_src_App_js@v1.should keep a separate cache entry for each cacheKey: loadv1, resolve and loadv2(fetch: true), resolvev1again (fetch: false, its cache entry is still there). Without the change, the last step fetches again, becausev2replaced the entry.🤖 Generated with Claude Code