Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make getResolveOptions callable without platform #984

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Feb 13, 2025

Summary

getResolveOptions can be now called without any params and the platform extensions will be resolved automatically. This makes getResolveOptions useful when used in static configs where platform variable isn't exposed.

  • - added overload to getResolveOptions making it possible to be called without any params
  • - added tests for getResolveOptions which test the new behaviour and ensure backwards-compatibility of changes
  • - removed redundant platform argument from configs and templates

Test plan

  • - tests pass
  • - testers work

Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: bec1e4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/repack Major
@callstack/repack-plugin-expo-modules Major
@callstack/repack-plugin-nativewind Major
@callstack/repack-plugin-reanimated Major
@callstack/repack-dev-server Major
@callstack/repack-init Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:00pm

@jbroma jbroma merged commit 1f470a1 into main Feb 13, 2025
5 checks passed
@jbroma jbroma deleted the refactor/resolve-options branch February 13, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants