Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getJsTransformRules #991

Merged
merged 37 commits into from
Feb 17, 2025
Merged

feat: getJsTransformRules #991

merged 37 commits into from
Feb 17, 2025

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Feb 14, 2025

Summary

  • - added getJsTransformRules which has all necessary rules for using Rspack React Native
  • - added getSwcLoaderOptions which has all necessary rules for using Rspack with swc
  • - added getFlowTransformRules which handles stripping flow types from a predefined set of libraries that use flow
  • - added getCodegenTransformRules which handles RN codegen transform like in @react-native/babel-preset
  • - removed static rules which were used in previous RC releases
  • - removed CodegenPlugin since it has become redundant
  • - added docs for all new helper functions
  • - added jsdocs for all new helper functions
  • - updated tester apps with the new helper functions
  • - updated templates with the new helper functions

Test plan

  • - tests pass
  • - testers work

Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: ddf547d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/repack Major
@callstack/repack-plugin-expo-modules Major
@callstack/repack-plugin-nativewind Major
@callstack/repack-plugin-reanimated Major
@callstack/repack-dev-server Major
@callstack/repack-init Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 11:04am

@jbroma jbroma requested a review from thymikee February 15, 2025 15:24
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. A small test suite would be welcome 👍

@jbroma jbroma marked this pull request as ready for review February 16, 2025 20:18
@jbroma
Copy link
Member Author

jbroma commented Feb 16, 2025

@thymikee @szymonrybczak

I've added docs & jsdocs to the functions, please do a final review before we merge this one since it's a big one.

I've skipped adding tests since almost everything here is declarative and the best way to test this is through already existing start/bundle tests

@jbroma jbroma removed the request for review from szymonrybczak February 17, 2025 11:14
@jbroma jbroma merged commit c36f778 into main Feb 17, 2025
5 checks passed
@jbroma jbroma deleted the feat/get-js-transform-rules branch February 17, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants