Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: null element support (POC) #104

Closed
wants to merge 1 commit into from
Closed

Conversation

mdjastrzebski
Copy link
Member

Summary

Test plan

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.25000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (d218336) to head (264d123).

Files with missing lines Patch % Lines
src/constructs/quantifiers.ts 66.66% 3 Missing ⚠️
src/encoder.ts 84.61% 2 Missing ⚠️
src/builders.ts 83.33% 1 Missing ⚠️
src/constructs/capture.ts 75.00% 1 Missing ⚠️
src/constructs/char-class.ts 88.88% 1 Missing ⚠️
src/constructs/lookahead.ts 75.00% 1 Missing ⚠️
src/constructs/lookbehind.ts 75.00% 1 Missing ⚠️
src/constructs/negative-lookahead.ts 75.00% 1 Missing ⚠️
src/constructs/negative-lookbehind.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #104      +/-   ##
===========================================
- Coverage   100.00%   93.58%   -6.42%     
===========================================
  Files           17       17              
  Lines          160      187      +27     
  Branches        42       55      +13     
===========================================
+ Hits           160      175      +15     
- Misses           0       12      +12     
Flag Coverage Δ
93.58% <81.25%> (-6.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants