Add maxColumns Configuration to Columns Tool#22
Open
zorexsalvo wants to merge 6 commits into
Open
Conversation
- Added a "4 Columns" option to the column settings menu. - Updated the _updateCols method to handle 4 columns. - This allows users to create and manage up to 4 columns in the editor.
Allow users to select 2, 3, or 4 columns in the editor settings. Refactored _updateCols to use the provided column count argument.
Refactor renderSettings to generate column controls dynamically based on maxColumns. Added documentation comment for clarity and maintainability.
Owner
|
Did you get this to a state where you would open a pull? I would consider it as long as it doesn't break any existing implementations |
Author
|
Hi @calumk, thanks for taking a look. It’s still in draft state as I’m still reading the Editor.js API. And yes, I made sure that it will not break any existing implementation. |
Owner
|
Yes the editors API is... Not the best documented! |
maxColumns Configuration to Columns Tool
Author
|
Hi @calumk thank you for your patience. This is now ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
maxColumns_updateColsfunctionThe columns tool now accepts a
maxColumnsparameter.Example usage:
this extends the maximum number of columns a user can create to 4.
Note: PR is still in draft state.