Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing security features #23

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

tlohmar
Copy link
Contributor

@tlohmar tlohmar commented Mar 9, 2025

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

The Pull Request enhances the API specification with a security scheme and scopes for authorization, following the CAMARA security considerations.

Which issue(s) this PR fixes:

Fixes Issue #22

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@tlohmar tlohmar requested a review from SteveV-Vodafone March 9, 2025 14:56
@tlohmar tlohmar changed the title Authz Enhancing security features Mar 9, 2025
Copy link

@PeterKovacs2 PeterKovacs2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scopes for DELETE operations should use the :delete suffix instead of the :destroy suffix for consistency with the HTTP operation names.

This is also supported by the Camara API Design Duidnes on Scope naming.

Copy link

@PeterKovacs2 PeterKovacs2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants