fix: comment out non-HTTP protocol support (not yet used in CAMARA)#64
Merged
hdamker-bot merged 2 commits intocamaraproject:mainfrom Apr 2, 2026
Merged
Conversation
Comment out MQTT3, MQTT5, AMQP, NATS, KAFKA protocol references in both sample-service-subscriptions.yaml and CAMARA_event_common.yaml. Comments signal future extensibility; bundled output is now HTTP-only. Changes: - Protocol enum: converted to block sequence, only HTTP active - Discriminator mappings: only HTTP mapping active - Protocol-specific schemas: 8 non-HTTP schemas commented out - Settings schemas: MQTTSettings, AMQPSettings, ApacheKafkaSettings, NATSSettings commented out, HTTPSettings remains
hdamker-bot
previously approved these changes
Apr 2, 2026
yamllint comments-indentation requires comments to match the indent of the next non-comment content. Commented-out schemas at end of file had no following content (indent 0), triggering the warning. Moving them into the section header block before the active HTTP schemas fixes this.
hdamker-bot
approved these changes
Apr 2, 2026
hdamker
added a commit
to hdamker/Commonalities
that referenced
this pull request
Apr 2, 2026
Comment out MQTT3, MQTT5, AMQP, NATS, KAFKA protocol references in both sample-service-subscriptions.yaml and CAMARA_event_common.yaml. Comments signal future extensibility; bundled output is now HTTP-only. Changes: - Protocol enum: converted to block sequence, only HTTP active - Discriminator mappings: only HTTP mapping active - Protocol-specific schemas: 8 non-HTTP schemas commented out - Settings schemas: MQTTSettings, AMQPSettings, ApacheKafkaSettings, NATSSettings commented out, HTTPSettings remains Validated on camaraproject/ReleaseTest#64 (bundling + yamllint + spectral).
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Comments out non-HTTP protocol references (MQTT3, MQTT5, AMQP, NATS, KAFKA) in both
sample-service-subscriptions.yamlandCAMARA_event_common.yaml, as proposed by the Commonalities WG for Commonalities#606.Comments stay in the source files signaling future extensibility. After bundling, only HTTP-related schemas appear in the output.
Changes:
HTTPactiveWhich issue(s) this PR fixes:
Testing ground for Commonalities#606 protocol commenting proposal.
Special notes for reviewers:
Validated locally:
redocly bundle: succeeds, bundled output contains zero non-HTTP referencesspectral lint(r4 ruleset): 0 errors, 14 pre-existing warnings (no new warnings from this change)Changelog input
Additional documentation