Skip to content

feat!: drop hacluster support and the ha interface - #699

Merged
Thanhphan1147 merged 11 commits into
mainfrom
foreman/ISD-7413
Nov 13, 2026
Merged

Thanhphan1147 merged 11 commits into
mainfrom
foreman/ISD-7413

Conversation

@Thanhphan1147

@Thanhphan1147 Thanhphan1147 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Drops hacluster support from the HAProxy charm (ISD-7413).

  • Removes the ha relation endpoint, the vip config option, and the HA state module.
  • Removes the logic that added VIP-backed resources to hacluster and propagated the VIP through haproxy-peers.
  • TCP proxied endpoints now always use per-unit peer addresses (or SNI when configured).
  • DNS records now always use the ingress binding address.
  • Removes the interface-hacluster dependency and the hacluster VIP Loki alert rules.
  • Removes the hacluster unit/integration tests and hacluster-specific docs pages.
  • Removes hacluster support from the Terraform product module; keepalived remains the supported HA integration.

Verification

  • tox -e lint,static,unit in haproxy-operator/: lint OK, static OK, unit OK (357 passed)
  • make -C docs html (build succeeded)
  • Confirmed no remaining ha/hacluster/vip references in charm source, tests, or config; remaining virtual-IP docs refer to keepalived.

Decisions

  • Removing hacluster from the Terraform product module is in scope: the charm no longer exposes the ha endpoint the module integrated with. keepalived remains supported.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Documentation and runtime verification remain incomplete because the local Sphinx environment could not be established or retried cleanly, leaving the endpoint-removal change without independent validation.

No open issues 🎉

What changed in this PR

This breaking-change PR removes the HAProxy charm’s hacluster integration and VIP-based HA behavior while retaining keepalived as the supported HA option.

Changes:

  • Removed the ha relation, vip configuration, HA state module, dependency, alerts, tests, and legacy fixtures.
  • Updated TCP endpoint publication to use SNI or per-unit peer addresses and DNS records to use the ingress binding address.
  • Removed hacluster support from Terraform and updated documentation, redirects, release notes, and charm metadata.
File Summary
terraform/​product/​variables.tf Removes the hacluster input and mutual-exclusion validation.
terraform/​product/​README.md Removes hacluster resources and integration documentation.
terraform/​product/​main.tf Removes hacluster deployment and integration resources.
terraform/​charm/​haproxy/​variables.tf Removes hacluster-specific unit-count guidance.
terraform/​charm/​haproxy/​README.md Updates module documentation without obsolete HA inputs.
terraform/​charm/​haproxy/​outputs.tf Removes the obsolete ha endpoint output.
spread.yaml Removes the legacy hacluster test environment.
haproxy-operator/​uv.lock Removes hacluster-related dependencies.
haproxy-operator/​tests/​unit/​test_haproxy_route_tcp_proxied_endpoints.py Removes VIP-based endpoint tests and updates peer-address coverage.
haproxy-operator/​tests/​unit/​test_charm.py Removes VIP DNS coverage and retains ingress-binding coverage.
haproxy-operator/​tests/​unit/​legacy/​test_ha.py Removes hacluster unit tests.
haproxy-operator/​tests/​integration/​legacy/​test_ha.py Removes the hacluster integration test.
haproxy-operator/​tests/​integration/​legacy/​conftest.py Removes the hacluster deployment fixture.
haproxy-operator/​src/​state/​ha.py Deletes the obsolete HA state module.
haproxy-operator/​src/​loki_alert_rules/​hacluster_vip_stopped.rule Removes the hacluster VIP-stopped alert.
haproxy-operator/​src/​loki_alert_rules/​hacluster_vip_started.rule Removes the hacluster VIP-started alert.
haproxy-operator/​src/​loki_alert_rules/​hacluster_node_lost.rule Removes the hacluster node-lost alert.
haproxy-operator/​src/​loki_alert_rules/​hacluster_no_quorum.rule Removes the hacluster no-quorum alert.
haproxy-operator/​src/​charm.py Removes hacluster handling and uses peer, SNI, and ingress addresses.
haproxy-operator/​pyproject.toml Removes the hacluster interface dependency.
haproxy-operator/​charmcraft.yaml Removes the ha relation and vip configuration option.
docs/​tutorial/​getting-started.md Removes hacluster references from the tutorial.
docs/​release-notes/​artifacts/​isd-7413.yaml Documents the breaking removal of hacluster support.
docs/​reference/​terraform.md Documents keepalived as the supported Terraform HA integration.
docs/​reference/​relation-endpoints.md Removes the ha relation endpoint reference.
docs/​redirects.txt Redirects the deleted OpenStack VIP guide to the HA guide.
docs/​index.md Replaces the deleted OpenStack VIP navigation entry.
docs/​how-to/​index.md Updates HA guidance for keepalived and removes the deleted guide.
docs/​how-to/​configure-virtual-ip-on-openstack.md Deletes the hacluster-specific OpenStack VIP guide.
docs/​explanation/​high-availability.md Updates HA documentation to describe keepalived support.
docs/​conf.py Removes the obsolete hacluster linkcheck exception.
concierge-lxd-juju3.yaml Removes the legacy hacluster test environment configuration.

Review effort: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants