Repository navigation
feat!: drop hacluster support and the ha interface - #699
Merged
Merged
Conversation
Thanhphan1147
force-pushed
the
foreman/ISD-7413
branch
from
November 3, 2026 09:37
12f8776 to
d047d13
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Documentation and runtime verification remain incomplete because the local Sphinx environment could not be established or retried cleanly, leaving the endpoint-removal change without independent validation.
No open issues 🎉
What changed in this PR
This breaking-change PR removes the HAProxy charm’s hacluster integration and VIP-based HA behavior while retaining keepalived as the supported HA option.
Changes:
- Removed the
harelation,vipconfiguration, HA state module, dependency, alerts, tests, and legacy fixtures. - Updated TCP endpoint publication to use SNI or per-unit peer addresses and DNS records to use the ingress binding address.
- Removed hacluster support from Terraform and updated documentation, redirects, release notes, and charm metadata.
| File | Summary |
|---|---|
terraform/product/variables.tf |
Removes the hacluster input and mutual-exclusion validation. |
terraform/product/README.md |
Removes hacluster resources and integration documentation. |
terraform/product/main.tf |
Removes hacluster deployment and integration resources. |
terraform/charm/haproxy/variables.tf |
Removes hacluster-specific unit-count guidance. |
terraform/charm/haproxy/README.md |
Updates module documentation without obsolete HA inputs. |
terraform/charm/haproxy/outputs.tf |
Removes the obsolete ha endpoint output. |
spread.yaml |
Removes the legacy hacluster test environment. |
haproxy-operator/uv.lock |
Removes hacluster-related dependencies. |
haproxy-operator/tests/unit/test_haproxy_route_tcp_proxied_endpoints.py |
Removes VIP-based endpoint tests and updates peer-address coverage. |
haproxy-operator/tests/unit/test_charm.py |
Removes VIP DNS coverage and retains ingress-binding coverage. |
haproxy-operator/tests/unit/legacy/test_ha.py |
Removes hacluster unit tests. |
haproxy-operator/tests/integration/legacy/test_ha.py |
Removes the hacluster integration test. |
haproxy-operator/tests/integration/legacy/conftest.py |
Removes the hacluster deployment fixture. |
haproxy-operator/src/state/ha.py |
Deletes the obsolete HA state module. |
haproxy-operator/src/loki_alert_rules/hacluster_vip_stopped.rule |
Removes the hacluster VIP-stopped alert. |
haproxy-operator/src/loki_alert_rules/hacluster_vip_started.rule |
Removes the hacluster VIP-started alert. |
haproxy-operator/src/loki_alert_rules/hacluster_node_lost.rule |
Removes the hacluster node-lost alert. |
haproxy-operator/src/loki_alert_rules/hacluster_no_quorum.rule |
Removes the hacluster no-quorum alert. |
haproxy-operator/src/charm.py |
Removes hacluster handling and uses peer, SNI, and ingress addresses. |
haproxy-operator/pyproject.toml |
Removes the hacluster interface dependency. |
haproxy-operator/charmcraft.yaml |
Removes the ha relation and vip configuration option. |
docs/tutorial/getting-started.md |
Removes hacluster references from the tutorial. |
docs/release-notes/artifacts/isd-7413.yaml |
Documents the breaking removal of hacluster support. |
docs/reference/terraform.md |
Documents keepalived as the supported Terraform HA integration. |
docs/reference/relation-endpoints.md |
Removes the ha relation endpoint reference. |
docs/redirects.txt |
Redirects the deleted OpenStack VIP guide to the HA guide. |
docs/index.md |
Replaces the deleted OpenStack VIP navigation entry. |
docs/how-to/index.md |
Updates HA guidance for keepalived and removes the deleted guide. |
docs/how-to/configure-virtual-ip-on-openstack.md |
Deletes the hacluster-specific OpenStack VIP guide. |
docs/explanation/high-availability.md |
Updates HA documentation to describe keepalived support. |
docs/conf.py |
Removes the obsolete hacluster linkcheck exception. |
concierge-lxd-juju3.yaml |
Removes the legacy hacluster test environment configuration. |
Review effort: Lite
Drop the juju3 concierge config used only by the legacy HA test, add a docs redirect for the removed virtual IP how-to, and tidy the high-availability explanation.
Thanhphan1147
force-pushed
the
foreman/ISD-7413
branch
from
November 7, 2026 13:55
e7eb79d to
5e5f94e
Compare
Thanhphan1147
marked this pull request as draft
November 7, 2026 13:57
Thanhphan1147
marked this pull request as ready for review
November 7, 2026 13:59
Thanhphan1147
marked this pull request as draft
November 8, 2026 19:57
Thanhphan1147
commented
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops hacluster support from the HAProxy charm (ISD-7413).
harelation endpoint, thevipconfig option, and the HA state module.haproxy-peers.interface-haclusterdependency and the hacluster VIP Loki alert rules.keepalivedremains the supported HA integration.Verification
tox -e lint,static,unitinhaproxy-operator/: lint OK, static OK, unit OK (357 passed)make -C docs html(build succeeded)ha/hacluster/vipreferences in charm source, tests, or config; remaining virtual-IP docs refer tokeepalived.Decisions
haendpoint the module integrated with.keepalivedremains supported.