Repository navigation
feat!: drop legacy reverseproxy and website relations - #700
Merged
Merged
Conversation
Move the haproxy charm base to ubuntu@26.04, which provides HAProxy 3.2, and publish the charm on the 3.2 track. Update integration tests, Terraform defaults, docs, and CI promotion workflows, and add a workload version check.
- Keep the hacluster fixture on ubuntu@24.04 and xfail the HA test since hacluster does not support ubuntu@26.04. - Remove the workload version integration test. - Document high availability with the keepalived subordinate charm instead of the deprecated hacluster charm.
3 of 9 tasks
Thanhphan1147
commented
Nov 2, 2026
Thanhphan1147
marked this pull request as ready for review
November 2, 2026 23:35
Send the HTTP/TCP request inside the log-hash retry loop so it is logged by the reloaded HAProxy worker. Retry the route-policy relation update when the any-charm requirer runs before the relation is ready. Keep grafana-agent, hacluster and keepalived on ubuntu@24.04 in the terraform product module, and pin the terraform test deployment to the published 2.8/edge revision while the 3.2 track is not yet available.
This reverts commit bbb26b9.
Thanhphan1147
force-pushed
the
foreman/ISD-6909
branch
from
November 3, 2026 09:38
8b296e5 to
73f415d
Compare
Thanhphan1147
marked this pull request as draft
November 3, 2026 09:38
seb4stien
reviewed
Nov 3, 2026
seb4stien
approved these changes
Nov 3, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The breaking removal of live Juju relation endpoints and legacy reconciliation remains insufficiently validated because runtime tests, integration checks, and Sphinx documentation/lint builds could not run, requiring CI or human verification.
No open issues 🎉
What changed in this PR
This breaking change removes the deprecated reverseproxy and website relations and their legacy HAProxy implementation, leaving the supported haproxy-route integrations.
Changes:
- Removed legacy relation interfaces, reconciliation logic, state mode, template, endpoints, tests, and fixtures.
- Updated Terraform outputs, charm metadata, coverage configuration, and service reload tests.
- Updated relation documentation and release notes to reflect the breaking removal.
| File | Description |
|---|---|
terraform/product/outputs.tf |
Removes the product-level reverseproxy requirement output. |
terraform/charm/haproxy/outputs.tf |
Removes the HAProxy module’s reverseproxy requirement output. |
haproxy-operator/tests/unit/test_state.py |
Updates state tests for removal of the legacy relation. |
haproxy-operator/tests/unit/test_haproxy_service.py |
Tests consolidated reload failure handling. |
haproxy-operator/tests/integration/legacy/test_website.py |
Removes legacy website relation integration coverage. |
haproxy-operator/tests/integration/legacy/test_http_interface.py |
Removes legacy reverse-proxy integration coverage. |
haproxy-operator/tests/integration/legacy/conftest.py |
Removes fixtures used by legacy relation tests. |
haproxy-operator/templates/haproxy_legacy.cfg.j2 |
Removes the legacy HAProxy configuration template. |
haproxy-operator/src/state/charm_state.py |
Removes legacy proxy mode and validation inputs. |
haproxy-operator/src/legacy.py |
Removes the legacy HAProxy implementation. |
haproxy-operator/src/http_interface.py |
Removes the legacy HTTP relation implementation. |
haproxy-operator/src/haproxy.py |
Removes legacy reconciliation and consolidates reload errors. |
haproxy-operator/src/charm.py |
Removes legacy endpoints, handlers, observers, and reconciliation paths. |
haproxy-operator/pyproject.toml |
Removes coverage exclusion for the deleted legacy module. |
haproxy-operator/charmcraft.yaml |
Removes the reverseproxy and website endpoints. |
docs/release-notes/artifacts/pr0700.yaml |
Documents the breaking removal and supported replacements. |
docs/reference/relation-endpoints.md |
Removes legacy endpoint documentation and examples. |
Review effort: Lite
Collaborator
Author
|
[merge bot]: This PR is now being monitored to automatically rerun failing tests |
Co-authored-by: Thanhphan1147 <42444001+Thanhphan1147@users.noreply.github.com>
Thanhphan1147
marked this pull request as ready for review
November 13, 2026 17:14
Thanhphan1147
enabled auto-merge (squash)
November 13, 2026 17:14
Thanhphan1147
marked this pull request as draft
November 16, 2026 06:48
auto-merge was automatically disabled
November 16, 2026 06:48
Pull request was converted to draft
Juju 4 removed the --storage flag from add-k8s. Detect the Juju major version and only pass --storage on Juju 3, which is still used by the test_oauth_spoe task. The docs spread tutorial cannot run pollinate because logger cannot write to syslog in the spread environment. Keep the pollinate instructions in the tutorial but verify the route with curl in spread.
The previous route check ran before the haproxy-route relation was applied and expected a successful HTTP status. Wait for pollen to become active and match pollen's intentional 400 response instead.
Thanhphan1147
marked this pull request as ready for review
November 16, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
reverseproxyandwebsiterelation endpoints, the legacy HTTP interface implementation (src/http_interface.py), the legacy HAProxy config template, andsrc/legacy.py.CharmStateand the corresponding reconcile path incharm.py.spread.yamlno longer passes--storagetojuju add-k8son Juju 4, where the flag was removed. It keeps--storage csi-rawfile-defaultfor the Juju 3test_oauth_spoetask.curlbecausepollinatecannot write to syslog in the spread environment. The human-facingpollinateinstructions remain in the tutorial..opencode/to.gitignoreso agent state is never committed.Why we need it
ISD-6909 drops support for the deprecated legacy relations. The CI changes unblock the shared integration and docs checks after the Juju 4.1 and CK8s environment changes.
Checklist
docs/changelog.mdwith user-relevant changesdocs/release-notes/artifacts. If no change artifact is necessary, I tagged the PR with the labelno-release-note.(e.g., in
.github/workflows/integration_tests.yaml, ensure themoduleslist is correct)terraform fmtpasses andtflintreports no errorsTest plan
tox -e lint,unitinhaproxy-operator/: 364 unit tests passed, lint clean.opcli tutorial expandondocs/tutorial/getting-started.md: generated spread script uses the newcurlroute check and excludes thepollinateblock.spread.yamlparses as valid YAML.bindinstall failure and apostgresqlstorage-attachedfailure) passed on rerun.Review focus
tests/integration/spread prepare step.SPREAD SKIPapproach that keeps the tutorial'spollinateinstructions for humans while testing the route withcurlin CI.Potential breaking changes
reverseproxyandwebsiterelation endpoints are removed. Integrators must usehaproxy-routeorhaproxy-route-tcp.New dependencies, APIs, modules, or workflow changes
spread.yamlprepare logic now depends on the installed Juju major version.