Skip to content

Verify commit signoff GHA #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AnneCYH merged 1 commit into from
Dec 2, 2024
Merged

Verify commit signoff GHA #24

AnneCYH merged 1 commit into from
Dec 2, 2024

Conversation

@AnneCYH
Copy link
Collaborator

@AnneCYH AnneCYH commented Nov 26, 2024 •
edited
Loading

Add GitHub Action workflow that checks that commits are signed off (-s or --signoff).

@AnneCYH AnneCYH force-pushed the annecyh/verify-commit-signoffs branch 2 times, most recently from f7c00a2 to f0930e0 Compare November 26, 2024 06:10
@AnneCYH AnneCYH marked this pull request as ready for review November 26, 2024 06:11
benjamin051000
benjamin051000 requested changes Nov 26, 2024
View reviewed changes
@AnneCYH AnneCYH force-pushed the annecyh/verify-commit-signoffs branch from 87bed41 to c3b3fab Compare November 27, 2024 05:50
@AnneCYH AnneCYH marked this pull request as draft November 27, 2024 06:00
@AnneCYH AnneCYH marked this pull request as ready for review November 27, 2024 06:00
@AnneCYH AnneCYH force-pushed the annecyh/verify-commit-signoffs branch 6 times, most recently from 5bb233a to 215cbcf Compare November 27, 2024 06:35
@AnneCYH
Add GHA to verify commit sign off
9bd74a1 
Signed-off-by: annecyh <anne.chew@canonical.com>
@AnneCYH AnneCYH force-pushed the annecyh/verify-commit-signoffs branch from 8695a65 to 9bd74a1 Compare November 27, 2024 06:42
benjamin051000
benjamin051000 approved these changes Dec 2, 2024
View reviewed changes
Copy link

@benjamin051000 benjamin051000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is working as intended, LGTM.

@AnneCYH AnneCYH merged commit eb902a9 into main Dec 2, 2024
1 check passed
@AnneCYH
Copy link
Collaborator Author

AnneCYH commented Dec 2, 2024

Thanks @benjamin051000

For reference, there's a DCO app which can be installed but i'm still trying to get it enabled for other repos
once done i'll enable the same thing here since it's cleaner to implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamin051000 benjamin051000 benjamin051000 approved these changes

@gagath gagath Awaiting requested review from gagath

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AnneCYH @benjamin051000