Ignore idle inhibit if the session is locked manually

[brenton-leighton]

Summary

Currently if an idle inhibit is active (like when playing a video) and the session is manually locked (e.g. by running swaylock), the session locks but the output is never turned off. I think typical behavior is to ignore idle inhibit when the session is locked manually.

Details

No response

Prior Art

No response

[AlanGriffiths]

Have you set idle-timeout-when-locked?

[brenton-leighton]

Yes I have:

MIR_SERVER_IDLE_TIMEOUT=300
MIR_SERVER_IDLE_TIMEOUT_WHEN_LOCKED=5

The screen does turn off when locked when there's no video playing.

[AlanGriffiths]

Thanks for the clarification.

It looks like all the logic is in BasicIdleHub and this is simply a usecase that was overlooked. Marking as a "Good first issue" - will try to get this addressed quickly

[tayfuryldz]

I can take this. I’ll keep the change in BasicIdleHub: make the locked idle timeout ignore active idle inhibitors after a manual lock, add a focused regression for inhibit + lock while preserving normal inhibitor behavior when unlocked, and run the relevant idle-hub test target.