o/confdbstate: add helper to schedule load confdb hook/tasks #15110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loading change will reuse GetStoredTransaction to obtain the transaction stored or linked by a task. However, the confdb loading doesn't commit anything so it doesn't make sense to store the task ID under "commit-task". This changes that to "tx-task". Signed-off-by: Miguel Pires <[email protected]>
Refactors the accumulating of custodian snap names into the same function that looks for relevant plugs so we don't need to duplicate it in when we implement something similar for the loading confdb change. Signed-off-by: Miguel Pires <[email protected]>
Signed-off-by: Miguel Pires <[email protected]>
miguelpires
added
the
confdb
github-actions
bot
added
the
Needs Documentation -auto-
|
Tue Feb 25 12:12:44 UTC 2025 Failures:Executing:
|
ZeyadYasser
reviewed
Feb 24, 2025
Signed-off-by: Miguel Pires <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15110 +/- ##
==========================================
+ Coverage 78.07% 78.15% +0.08%
==========================================
Files 1182 1177 -5
Lines 157743 157871 +128
==========================================
+ Hits 123154 123387 +233
+ Misses 26943 26830 -113
- Partials 7646 7654 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
81070b9 changes the key used to link tasks to the transaction carrying task
c3aca30 is a small refactor to prevent duplicating some code in the new helper
5490fc1 adds support for the query-view and load-view hooks as well as a helper that schedules tasks appropriately