core-initrd: make Azure kernels reboot upon panic #15123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the "panic=60" kernel cmdline option for Azure kernels in order to make them reboot after 60s upon a panic during boot. This will be relevant for implementing a fallback mechanism in nullboot, allowing rollbacks in the event of a faulty kernel upgrade. The 60s timeout is chosen to allow easier collection of console logs during troubleshooting. Signed-off-by: Vinicius Peixoto <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15123 +/- ##
==========================================
- Coverage 78.07% 78.06% -0.01%
==========================================
Files 1182 1184 +2
Lines 157743 158016 +273
==========================================
+ Hits 123154 123360 +206
- Misses 26943 26990 +47
- Partials 7646 7666 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Tue Feb 25 12:21:08 UTC 2025 No spread failures reported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the "panic=60" kernel cmdline option for Azure kernels in order to make them reboot after 60s upon a panic during boot. This will be relevant for implementing a fallback mechanism in nullboot, allowing rollbacks in the event of a faulty kernel upgrade. The 60s timeout is chosen to allow easier collection of console logs during troubleshooting.
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?