cmd/snap-discard-ns: asssert process capabilities #15144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15144 +/- ##
========================================
Coverage 78.07% 78.07%
========================================
Files 1182 1184 +2
Lines 157743 158224 +481
========================================
+ Hits 123154 123538 +384
- Misses 26943 27005 +62
- Partials 7646 7681 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Fri Feb 28 09:55:13 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
zyga
approved these changes
Feb 27, 2025
| @@ -63,6 +90,11 @@ int main(int argc, char** argv) { | |||
| sc_instance_name_validate(snap_instance_name, &err); | |||
| sc_die_on_error(err); | |||
|
|
|||
| /* time to asssert we have the right capabilities to perform the job */ | |||
| assert_caps(); | |||
| /* TODO: drop superfluous capabiltiies and keep only the ones that are | |||
There was a problem hiding this comment.
Suggested change
| /* TODO: drop superfluous capabiltiies and keep only the ones that are | |
| /* TODO: drop superfluous capabilities and keep only the ones that are |
alexmurray
requested changes
Feb 28, 2025
| const char* cap_name SC_CLEANUP(cap_free) = cap_to_name(cap); | ||
|
|
||
| cap_flag_value_t set = CAP_CLEAR; | ||
| if (cap_get_flag(current, CAP_SYS_ADMIN, CAP_EFFECTIVE, &set) != 0) { |
There was a problem hiding this comment.
This looks like a typo - I am guessing CAP_SYS_ADMIN be cap so we query each capability rather than repeatedly querying for CAP_SYS_ADMIN.
There was a problem hiding this comment.
Thanks for catching. I've pushed a fixup.
Assert process capabilities, to ensure correctness when invoked from snap-confine. Signed-off-by: Maciej Borzecki <[email protected]>
bboozzoo
force-pushed
the
bboozoo/snap-discard-ns-caps-assert
branch
from
bc6da80 to
15d2157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert process capabilities, to ensure correctness when invoked from snap-confine.
Cherry picked from #15094. This is a preparatory step for having snap-discard-ns be invoked by a user with privileges carried by capabilities.
Related: SNAPDENG-34419