feat: make addresses indexes for orders optional#316
Open
pablocampogo wants to merge 1 commit intomainfrom
Open
feat: make addresses indexes for orders optional#316pablocampogo wants to merge 1 commit intomainfrom
pablocampogo wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IndexOrdersByAddressesconfiguration option toStateMachineConfigthat controls whether secondary indexes for order lookups by seller/buyer address are created/v1/query/ordersendpoint returns an error ifsellersSendAddressorbuyerSendAddressfilters are usedtrue(indexes enabled)Changes
Configuration (
lib/config.go)DefaultIndexOrdersByAddressesconstantIndexOrdersByAddressesfield toStateMachineConfigState Machine (
fsm/swap.go)SetOrder: Conditionally creates seller/buyer secondary indexes based on configcleanupStaleBuyerIndex: Skips cleanup when indexing is disabledDeleteOrder: Conditionally deletes seller/buyer secondary indexes based on configRPC Endpoint (
cmd/rpc/query.go)Orders: Returns descriptive error when address-based filtering is requested but indexing is disabled