Skip to content

init rework and config overrides #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 26, 2025
Merged

init rework and config overrides #101

merged 13 commits into from
May 26, 2025

Conversation

rlindner81
Copy link
Contributor

@rlindner81 rlindner81 commented Apr 16, 2025

relates to #100

  • init now throws if mandatory properties type or fallbackValue are missing or invalid
  • init now throws for double invocation and toggles.canInitialize can be used to check if an init is possible
  • configuration is read in the order
    • cds model feature toggles (automatically discovered)
    • configuration files, can be multiple
    • runtime configuration in passed inline during initialization, or via cds.env.featureToggles.config in plugin mode
  • each of these three "layers" can introduce new feature toggles or override existing feature toggles

TODO

  • try out double init blocking with big codebase
  • deeper look at override and validation behavior

@rlindner81 rlindner81 marked this pull request as ready for review May 23, 2025 15:14
@rlindner81 rlindner81 changed the title Fb/better config merging init rework and config overrides May 23, 2025
@rlindner81 rlindner81 merged commit 06fe0f4 into main May 26, 2025
7 checks passed
@rlindner81 rlindner81 deleted the fb/better-config-merging branch May 26, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant