fix: expand + groupby may return null, dont attach .element
#1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the column this is a workaround for an issue reported in cap/issues#17907 --> we need to put all this logic in the OData protocol adapter, this coding should not be necessary for the DB. This initiative has already started in #990
patricebender
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs,
sjvans and
David-Kunz
as code owners
patricebender
changed the title
.element to….element
BobdenOs
reviewed
Feb 26, 2025
johannes-vogel
approved these changes
Feb 27, 2025
Merged
johannes-vogel
added a commit
that referenced
this pull request
Mar 4, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.18.0</summary> ## [1.18.0](db-service-v1.17.2...db-service-v1.18.0) (2025-03-04) ### Added * query modifiers on expand `ref` are propagated to subquery ([#1049](#1049)) ([39fbadf](39fbadf)) * support query modifiers at leaf of from ref ([#1050](#1050)) ([500a666](500a666)) ### Fixed * `<expand>[@OData](https://github.com/odata).count` queries ([#966](#966)) ([6607a84](6607a84)) * align debug log format of stmt values ([#1052](#1052)) ([93af0fe](93af0fe)) * expand + groupby may return null, dont attach `.element` ([#1042](#1042)) ([cf2e0a2](cf2e0a2)) </details> <details><summary>sqlite: 1.9.0</summary> ## [1.9.0](sqlite-v1.8.0...sqlite-v1.9.0) (2025-03-04) ### Added * pass through of arbitrary client options ([#1024](#1024)) ([b090ccd](b090ccd)) </details> <details><summary>postgres: 1.12.0</summary> ## [1.12.0](postgres-v1.11.1...postgres-v1.12.0) (2025-03-04) ### Added * pass through of arbitrary client options ([#1024](#1024)) ([b090ccd](b090ccd)) ### Fixed * `<expand>[@OData](https://github.com/odata).count` queries ([#966](#966)) ([6607a84](6607a84)) </details> <details><summary>hana: 1.7.0</summary> ## [1.7.0](hana-v1.6.1...hana-v1.7.0) (2025-03-04) ### Added * pass through of arbitrary client options ([#1024](#1024)) ([b090ccd](b090ccd)) * support for `SELECT.hint` ([#1004](#1004)) ([2c6a763](2c6a763)) ### Fixed * `<expand>[@OData](https://github.com/odata).count` queries ([#966](#966)) ([6607a84](6607a84)) * Remove sub query alias check ([#953](#953)) ([e5a716c](e5a716c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Johannes Vogel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this resolves an
Uncaught Object.defineProperty called on non-objectdumpthis is a workaround for an issue reported in cap/issues#17907
--> we need to put all this logic in the OData protocol adapter, this coding should not be necessary for the DB. This initiative has already started in #990