Conversation
Update action.go to use Token.Span.Start instead of the removed Token.Index field. Add replace directive pointing to local carapace-shlex with v2 API. All tests pass. Assisted-by: Crush:glm-5.2
Replace manual token chain patterns with SplitForCompletion: - zsh/action.go: replace 4-regex quoting detection with ctx.QuotingState from SplitForCompletion using ZshFormat. Full-quoting state detection (FULL_QUOTING_*_STATE) now uses HasPrefix/HasSuffix on RawCurrentWord instead of regexes. Remove regexp import. - bash/patch.go: replace tokens.CurrentPipeline().FilterRedirects(). Words().Strings() chain with ctx.Words, redirect detection with ctx.IsRedirect, WordbreakPrefix() with ctx.Prefix. - cmd_clink/patch.go: same chain replacement with ctx.Words. - action.go:split(): use ctx.Words for pipeline args, ctx.QuotingState for value quoting, ctx.IsRedirect/ctx.CurrentWord for redirect target. Keep Split + pipelineTokens for prefix computation (Span-based prefix differs from ctx.Prefix which is wordbreak prefix). All tests pass. Assisted-by: Crush:glm-5.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update action.go to use Token.Span.Start instead of the removed
Token.Index field. Add replace directive pointing to local
carapace-shlex with v2 API. All tests pass.
Assisted-by: Crush:glm-5.2