fix(Layout): add Storybook controls - #23041
Open
Subhom1 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for v3-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v2-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23041 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 614 614
Lines 55161 55161
Branches 7863 7863
=======================================
Hits 49541 49541
Misses 5474 5474
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20974
Adds operative Storybook controls for the preview
Layoutstories in both React and Web Components. The stories now expose matchingdensityandsizecontrols with default args, keeping the control surface focused on props that actually affect the rendered layout demo.Changelog
New
densityandsizeto the ReactPreview/preview__Layoutstory.densityandsizeto the Web ComponentsPreview/preview__Layoutstory.Changed
densityradio controls andsizeselect controls for React and Web Components Layout stories.densityandsizeargs.Removed
Testing / Reviewing
Use the repository Node version:
Open React Storybook:
Open the
Preview/preview__Layoutdefault story and verify:densityandsize.densityupdates the rendered<Layout>context.sizeupdates the rendered<Layout>context.Open Web Components Storybook:
Open the
Preview/preview__Layoutdefault story and verify:densityandsize.densityupdates the rendered<cds-layout>context.sizeupdates the rendered<cds-layout>context.Run the focused tests and checks:
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
- [ ] Tested for cross-browser consistencyMore details can be found in the pull request guide