C++ Interop: Mapping std::string_view to Core.String
#6177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricknerb
added
proposal
bricknerb
force-pushed
the
proposal_string_view
branch
from
ef2c6d2 to
45a9801
Compare
github-actions
bot
added
proposal rfc
bricknerb
changed the title
std::string_viewstd::string_view to Core.String
|
The only real concern I have here is with the name But the leads have resolved #5969 to give us a set of names now -- could you update the proposal to capture the decision and some of the rationale? Let me know if the rationale in the issue doesn't make sense and happy to help there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal defines a direct, zero-cost mapping between C++'s
std::string_viewand Carbon'sCore.Stringfor C++ interoperability.The goal is to make C++ APIs that use
std::string_viewfeel native and seamless when used from Carbon.This mapping relies on the two types having an identical memory representation, a condition that we will work to ensure across all supported platforms.