-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Disambiguate "value binding" #6231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; I'm going to run this past some safety folks and other leads to make sure we have alignment.
I'm not opposed to trying to find some distinct terminology here, but I don't particularly like "value borrowing". Specifically, I'm very hesitant to begin using the term "borrow" until we have our safety design in mind and can make sure it a) doesn't conflict with that terminology, and b) isn't confusing when compared with Rust's use of the term. While maybe we end up with these looking very much like a "shared borrow" in Rust, jumping to that kind of terminology now makes me very nervous. It also seems hard to square with the existence of copy value representations. |
I've renamed "value borrowing" to "value acquisition", per Discord/offline discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for leads, thanks!
This proposal removes the definition of the term "value binding" as a primitive
category conversion from reference to value, replacing it with the term "value
acquisition". The other meaning of "value binding", a binding declared by a
value binding pattern, is unchanged.