Skip to content

Conversation

geoffromer
Copy link
Contributor

@geoffromer geoffromer commented Oct 16, 2025

This proposal removes the definition of the term "value binding" as a primitive
category conversion from reference to value, replacing it with the term "value
acquisition". The other meaning of "value binding", a binding declared by a
value binding pattern, is unchanged.

@geoffromer geoffromer added proposal draft Proposal in draft, not ready for review documentation An issue or proposed change to our documentation labels Oct 16, 2025
@geoffromer geoffromer marked this pull request as ready for review October 16, 2025 00:49
@geoffromer geoffromer requested review from a team as code owners October 16, 2025 00:49
@geoffromer geoffromer requested review from zygoloid and removed request for a team October 16, 2025 00:49
@geoffromer geoffromer added proposal rfc Proposal with request-for-comment sent out and removed proposal draft Proposal in draft, not ready for review labels Oct 16, 2025
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; I'm going to run this past some safety folks and other leads to make sure we have alignment.

@chandlerc
Copy link
Contributor

This proposal removes the definition of the term "value binding" as a primitive
category conversion from reference to value, replacing it with the term "value
borrowing".

I'm not opposed to trying to find some distinct terminology here, but I don't particularly like "value borrowing".

Specifically, I'm very hesitant to begin using the term "borrow" until we have our safety design in mind and can make sure it a) doesn't conflict with that terminology, and b) isn't confusing when compared with Rust's use of the term.

While maybe we end up with these looking very much like a "shared borrow" in Rust, jumping to that kind of terminology now makes me very nervous.

It also seems hard to square with the existence of copy value representations.

@geoffromer
Copy link
Contributor Author

I've renamed "value borrowing" to "value acquisition", per Discord/offline discussion.

@geoffromer geoffromer requested a review from zygoloid October 21, 2025 17:55
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for leads, thanks!

@zygoloid zygoloid added this pull request to the merge queue Oct 22, 2025
Merged via the queue into carbon-language:trunk with commit 39503a5 Oct 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation An issue or proposed change to our documentation proposal rfc Proposal with request-for-comment sent out proposal A proposal toolchain

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants