Avoid mismatched InterfaceId comparison between two files #6241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh11b
approved these changes
Oct 17, 2025
danakj
reviewed
Oct 17, 2025
danakj
reviewed
Oct 17, 2025
toolchain/check/impl_validation.cpp
Outdated
Comment on lines
373
to
376
| auto interface_owning_decl_id = interface.first_owning_decl_id; | ||
| if (!interface_owning_decl_id.has_value()) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
If first_owning_decl_id was None, the import_ir_id returned from GetIRId would be None, and we would have returned above, no?
There was a problem hiding this comment.
Oh, right, sorry - had meant to clean up/remove the GetIRId call, since this one caller now needs both parts of the ImportIRInst (both the ImportIRId, and the InstId).
Done that (though it did mean needing two !has_value() -> continue blocks) in 7558fe5
Co-authored-by: Dana Jansens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.