Skip to content

Fix up some comments related to the change to hex ids #6247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
Merged

Fix up some comments related to the change to hex ids #6247

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d14e364
Fix up some comments related to the change to hex ids
dwblaikie Oct 17, 2025
3c55969
Give full example of an inst name with a hex number
dwblaikie Oct 20, 2025
097b20a
Drop the 'such-as' since we have an example
dwblaikie Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions scripts/lldbinit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ def print_usage() -> None:
the `Label` string in `IdBase` classes to find possible TYPE names,
though only Id types that have a matching `Make...Id()` function are
supported.
ID is an integer number, such as `42`. This can be in hex (without the typical
0x prefix), such as `6000A`.
ID is an integer number, such as `42`, in hex, such as in `inst6000000A`.

Example usage:
# Dumps the `inst_id` local variable, with a `context` local variable.
Expand All @@ -75,8 +74,7 @@ def print_usage() -> None:

context = args[0]

# The set of "Make" functions in dump.cpp, and whether the ids are printed
# in decimal or hex.
# The set of "Make" functions in dump.cpp.
id_types = {
"class": "SemIR::MakeClassId",
"constant": "SemIR::MakeConstantId",
Expand Down
Loading