Add a base struct for singleton type insts #6289
Merged
+85
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danakj
approved these changes
Oct 29, 2025
Comment on lines
+1970
to
+1971
| // This is a singleton instruction. However, it may still evolve into a more | ||
| // standard type and be removed. |
There was a problem hiding this comment.
I've got a feeling at least half of these are just copy paste and don't actually make sense anymore, but I don't know what the comment means exactly so it's hard to say...
There was a problem hiding this comment.
Regarding what it means, I think zygoloid was thinking we'd want to construct them using more standard object representations, e.g. using TupleType, or perhaps just generating a bespoke type on demand, without a bespoke instruction.
I can't comment on whether TupleType is likely to happen, but I am mulling whether I can change these to eliminate the bespoke instructions, instead just having something like SingletonType that contains enough information to deduplicate itself.
Co-authored-by: Dana Jansens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just reducing boilerplate in
typed_insts.hbecause we have a number of singleton types, and keep adding more.The changes to
TemplateStringallowTemplateString IrNameto be used as aStringLiteral.