-
Notifications
You must be signed in to change notification settings - Fork 371
Refactoring of CIP113 specs #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of CIP113 specs #1004
Conversation
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
Co-authored-by: Ryan <[email protected]>
|
@matteocoppola I understand the need for a refactor given the huge progress that the authors & devs have made, but it would be unacceptable from a community review & editorial perspective to throw away the 2+ years of review on #444. Since the commit history of this branch is identical to #444 except for the last 6 commits, I'm closing this PR and asking you to please merge those commits into that branch. I can understand the changes are substantial but we are not really "starting over" here even if every line of the document has changed. Alternatively... We also had a suggestion from @colll78 (cc @michele-nuzzi) to "assign a new CIP number" which would effectively scrap CIP-0113. If all 3 authors agree (and post!) that's the best thing to do, please say so below this comment where that question has already been asked: #944 (review)
|
|
Sorry @rphair we are making you go crazy lately. @matteocoppola was trying to PR to the HarmonicLabs fork |
|
Apologies @rphair , the GitHub UI must have done some trickery, as Michele said I wanted to PR in his fork, there's no reason to wipe the history 😄 |
This PR contains a more organized structure of the CIP113 specs, with a few additional sections, one of which is the terminology to use unique definitions.
4 sections are still in TODO as they need to be filled/updated and it will be done in the next hours!