Skip to content

Conversation

@matteocoppola
Copy link

This PR contains a more organized structure of the CIP113 specs, with a few additional sections, one of which is the terminology to use unique definitions.

4 sections are still in TODO as they need to be filled/updated and it will be done in the next hours!

michele-nuzzi and others added 30 commits January 20, 2023 01:54
@rphair
Copy link
Collaborator

rphair commented Mar 14, 2025

@matteocoppola I understand the need for a refactor given the huge progress that the authors & devs have made, but it would be unacceptable from a community review & editorial perspective to throw away the 2+ years of review on #444.

Since the commit history of this branch is identical to #444 except for the last 6 commits, I'm closing this PR and asking you to please merge those commits into that branch. I can understand the changes are substantial but we are not really "starting over" here even if every line of the document has changed.

Alternatively... We also had a suggestion from @colll78 (cc @michele-nuzzi) to "assign a new CIP number" which would effectively scrap CIP-0113. If all 3 authors agree (and post!) that's the best thing to do, please say so below this comment where that question has already been asked: #944 (review)

  • That will imply the authors all agree the commentary on prior versions of the document is irrelevant, and in that case the editors won't insist upon keeping the document review history.
  • Upon getting that confirmation we would close CIP-0113? | Programmable tokens #444 instead and reopen this one... which we would admit into the CIP process as if it were a new submission... although benefited by the commit history above which shows how the document evolved.
  • We would then triage & certainly assign a new number for this PR at the next CIP meeting: https://hackmd.io/@cip-editors/108

cc @Ryun1 @Crypto2099 @perturbing

@rphair rphair closed this Mar 14, 2025
@michele-nuzzi
Copy link

Sorry @rphair we are making you go crazy lately.

@matteocoppola was trying to PR to the HarmonicLabs fork

@matteocoppola
Copy link
Author

Apologies @rphair , the GitHub UI must have done some trickery, as Michele said I wanted to PR in his fork, there's no reason to wipe the history 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants