-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Spidex to Showcase #1678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Add Spidex to Showcase #1678
Conversation
8f7c394 to
6a4a640
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hiiamtrong I see & appreciate your web site links to documentation that seems better than average for blockchain projects. Do you have any information about DEX usage? (I'm just asking because I haven't heard of your project before)
Hi @rphair, We integrate with multiple Cardano DEXs for swap aggregation.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging some others to hopefully merge soon (if agreed) since the outstanding change to fix the comma termination of the array would otherwise lead to more merge conflicts. cc @0xBora
39666b7 to
767d4be
Compare
767d4be to
91b1433
Compare
|
@hiiamtrong your force-push — which blew away all the collaborative review and response here — reversed the correction for the comma at the end of the array item you're adding. I'll re-review this when that issue can be attended to properly. |
force push restores code that violates coding standard
Sorry about that, I will restore the fix and push an update [Updated] Resolved at a46d20b |
|
@0xBora Can you help me take a look 👀 |
👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.
Checklist
yarn buildafter adding my changes without getting any errors.yarn.lock(or have removed these changes).Showcase addition
analyticsdex