Implementing chunkSize in writesql#106
Open
kjckang wants to merge 3 commits into
Open
Conversation
|
@kjckang hi I've created a pull request for this issue in November. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented chunkSize feature -
writesql has an additional parameter, chunkSize to determine the number of folds desired by user.
chunkSize is a number of folds to split dataframe and process incrementally by split.
The method currently only checks whether chunkSize is <= 0 or >= df.length(). Further checks on incorrect inputs such as string would be needed.
Closes #94