Use git credential helper

[ChrisBr]

Instead of using gh we should use the built in git credential helper to get a valid token. I think we could even get rid of reading the credentials files manually as git should be able to just do this for us.

What we're essentially doing is

> printf "host=github.com\nprotocol=https" | git credential fill
protocol=https
host=github.com
username=3799140
password=TOKEN

Ideally we would even hand down a path so the token could be scoped to a single repository.

https://git-scm.com/docs/gitcredentials

[ChrisBr]

Ideally I would like to do something like to scope it to a repository, can we somehow hand the repository down?

printf "host=github.com\nprotocol=https\npath=cargo-bins/cargo-binstall" | git credential fill

[NobodyXu]

Thanks!

According to gh-auth-login doc, the token could be stored in a system credential store, it only fallbacks if it's not available.

I suggest to fallback to git, if gh-auth-token fails

[ChrisBr]

@NobodyXu thanks, makes sense.

Do you see a way to scope the token per repository, that's what we're doing in CI for security reason. Or does cargo-binstall need a token valid for all repositories it attempts to download?

[NobodyXu]

Or does cargo-binstall need a token valid for all repositories it attempts to download?

Yes, it currently just reuses the same github-token for every repository of the crates to install.

[passcod]

I also want to say that on my system, using printf "host=github.com\nprotocol=https" | git credential fill does not return anything useful, while gh is currently logged in and binstall uses its token.

[ChrisBr]

I also want to say that on my system, using printf "host=github.com\nprotocol=https" | git credential fill does not return anything useful

Hum that's interesting. But your git client is authenticated and can push to Github? Or do you use gh for this?

I don't use gh myself and only use plain old git.

[passcod]

Yes, I can push to git, because that uses ssh keys.

[ChrisBr]

Yes, I can push to git, because that uses ssh keys.

Ah got it

[NobodyXu]

Pinging @ChrisBr

do you want to continue this PR or do you want me to take over?

[ChrisBr]

do you want to continue this PR or do you want me to take over?

Please take over but let me know if you run into any issues.