Skip to content

Revert "Bring back dependabot auto-merge workflow but don't use pull_request_target"#757

Merged
Enselic merged 1 commit intomainfrom
revert-755-auto-merge-again
Apr 18, 2025
Merged

Revert "Bring back dependabot auto-merge workflow but don't use pull_request_target"#757
Enselic merged 1 commit intomainfrom
revert-755-auto-merge-again

Conversation

@Enselic
Copy link
Copy Markdown
Member

@Enselic Enselic commented Apr 18, 2025

That didn't work. I have created a PR to improve GithUb docs: github/docs#37635

@Enselic Enselic enabled auto-merge April 18, 2025 08:51
@Enselic Enselic added this pull request to the merge queue Apr 18, 2025
Merged via the queue into main with commit ef594b3 Apr 18, 2025
8 checks passed
@Enselic Enselic deleted the revert-755-auto-merge-again branch April 18, 2025 08:55
@Emilgardis
Copy link
Copy Markdown
Member

Emilgardis commented Apr 18, 2025

Not sure I understand the reasoning here, this works just fine, looks to me like the merge queue is just misconfigured. There's no CI for the branches the merge queue creates (this is wrong, missed that we use merge_group)

@Enselic
Copy link
Copy Markdown
Member Author

Enselic commented Apr 18, 2025

(I'll reply in detail when I got time, currently busy)

Maybe your right, I didn't look super close

@Enselic
Copy link
Copy Markdown
Member Author

Enselic commented Apr 18, 2025

Ok I see you edited

I think the problem is that github token don't trigger workflows

Link in pr I linked to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants