Skip to content

add cline acp support#142

Open
maxpaulus43 wants to merge 1 commit intocarlos-algms:mainfrom
maxpaulus43:add-cline-acp
Open

add cline acp support#142
maxpaulus43 wants to merge 1 commit intocarlos-algms:mainfrom
maxpaulus43:add-cline-acp

Conversation

@maxpaulus43
Copy link

@maxpaulus43 maxpaulus43 commented Mar 4, 2026

Add Cline ACP support to agentic.nvim
https://docs.cline.bot/cline-cli/acp-editor-integrations

@coderabbitai
Copy link

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 60388ba3-b025-4a9c-b60d-3104594b0da2

📥 Commits

Reviewing files that changed from the base of the PR and between ce1ecb2 and 1a66277.

📒 Files selected for processing (3)
  • lua/agentic/acp/adapters/cline_acp_adapter.lua
  • lua/agentic/acp/agent_instance.lua
  • lua/agentic/config_default.lua

📝 Walkthrough

Walkthrough

The changes introduce a new ACP provider called "cline-acp" to the system. A new ClineACPAdapter class is created in a dedicated adapter module that extends ACPClient through metatable inheritance. The agent instance factory is updated to support instantiating this adapter when "cline-acp" is selected as the provider. Configuration defaults are extended with the new provider's metadata, including the display name "Cline ACP", executable command "cline", and default arguments ["--acp"].

Possibly related PRs

  • PR #88: Adds a new ACP provider adapter with corresponding provider branching and configuration entries following the same pattern
  • PR #137: Adds new ACP adapters integrated into the same code paths (adapter module, provider selection, and config defaults)

Poem

🐰 A cline adapter hops along,
With ACP's dance, both deep and strong,
Config entries, branches spread,
New providers leap ahead,
The pattern shines so clean and bright,
CodeRabbit sees extensibility done right! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate relevance to the changeset. Please add a description explaining the purpose and scope of adding Cline ACP support, even if brief.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'add cline acp support' clearly summarizes the main change: adding support for a new Cline ACP provider throughout the codebase.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Owner

@carlos-algms carlos-algms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @maxpaulus43, that's amazing, thanks for the Contribution.

Before we move forward and merge this, could you please ask it to perform these simple tasks:

  1. run ls in the current directory
  2. write a simple Fibonacci function in a new file
  3. search online for "lorem ipsum translation"
  4. What's in this api: https://swapi.dev/api/planets/3/
  5. (close and reopen) Launch a subagent to search where the Fibonacci is and if it's used

And maybe create a new comment with one screenshot for each?

If you check the existing provider files, you'll see each one have their own style.

I currently don't have access to Cline, and it would be amazing if it behaves similarly to the other providers.

@maxpaulus43
Copy link
Author

output.mp4

@maxpaulus43
Copy link
Author

subagent task:
image

@carlos-algms
Copy link
Owner

carlos-algms commented Mar 5, 2026

Thank you very much, the video was even better than I could have expected 😊

And it confirms my assumption, Cline has its own "style" of sending messages.

  1. the ls command had duplicated block (2 green completed tool calls)
  2. the ls command displayed no output (I would expect to see all folders and files)
  3. the new fibonnaci file showed no edit or write tool call (usually those come with a diff and the file content)
  4. the online search repeated the same URL multiple times, and had no actual output, or search result, just URLs.
  5. it's very strange it keeps a list of every prompt as a Task, it even confused itself at the end, repeating the ls results (but this doesn't seem solvable from our side)
  6. similar to the api fetch, it ran curl, but you got no response from the tool call, jsut the curl command.
  7. The tool block is using the fallback, last resort, title, so it becomes a little different from the other providers

Please, enable debug on your config, and monitor the ~/.cache/nvim/agentic_debug.log for message formats, and add IFs to deduplicate the tool calls, the URLs and normalise the tool call kind, argument, and body, especially around body, as it's duplicating content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants