Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Update trace-button.html #3559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SapanaJadhav
Copy link

Renamed the button name to re-run the benchmark from trace to TraceButton.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@SapanaJadhav
Copy link
Author

SapanaJadhav commented May 14, 2017 via email

@googlebot
Copy link

CLAs look good, thanks!

@anniesullie
Copy link
Contributor

Thanks so much for the pull request! But in catapult, we actually use rietveld for code reviews since it has integrated commit queue support. You can get instructions for sending a code review in rietveld here: https://github.com/catapult-project/catapult/blob/master/CONTRIBUTING.md

Feel free to send the review to my chromium account, [email protected].

@SapanaJadhav
Copy link
Author

Cloning to my local machine is failing.
I'm following [https://github.com/catapult-project/catapult/blob/master/CONTRIBUTING.md]
root@sapana-K52F:/home/sapana# git clone https://github.com/catapult-project/catapult.git
Cloning into 'catapult'...
remote: Counting objects: 123135, done.
remote: Compressing objects: 100% (172/172), done.
error: RPC failed; result=56, HTTP code = 200 MiB | 5.00 KiB/s
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed.
Plz tell me am i missing anything?

@anniesullie
Copy link
Contributor

I don't know what the problem is, but I googled git clone github fatal the remote end hung up unexpectedly and got a lot of results, maybe the suggestions in this stackoverflow post will help? http://stackoverflow.com/questions/6842687

@SapanaJadhav
Copy link
Author

Plz correct me where im doing wrong.
sapna@sapna:~/catapult$ git cl upload
Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...
Traceback (most recent call last):
File "/home/sapna/depot_tools/git_cl.py", line 5936, in
sys.exit(main(sys.argv[1:]))
File "/home/sapna/depot_tools/git_cl.py", line 5918, in main
return dispatcher.execute(OptionParser(), argv)
File "/home/sapna/depot_tools/subcommand.py", line 252, in execute
return command(parser, args[1:])
File "/home/sapna/depot_tools/git_cl.py", line 4812, in CMDupload
return cl.CMDUpload(options, args, orig_args)
File "/home/sapna/depot_tools/git_cl.py", line 1623, in CMDUpload
change=change)
File "/home/sapna/depot_tools/git_cl.py", line 1565, in RunHook
gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
File "/home/sapna/depot_tools/presubmit_support.py", line 1317, in DoPresubmitChecks
results += executer.ExecPresubmitScript(presubmit_script, filename)
File "/home/sapna/depot_tools/presubmit_support.py", line 1227, in ExecPresubmitScript
result = eval(function_name + '(*__args)', context)
File "", line 1, in
File "", line 133, in CheckChangeOnUpload
File "", line 116, in CheckChange
File "/home/sapna/catapult/catapult_build/js_checks.py", line 7, in
import eslint
File "/home/sapna/catapult/common/eslint/eslint/init.py", line 29, in
from node_runner import node_util
File "/home/sapna/catapult/common/eslint/eslint/../../../common/node_runner/node_runner/node_util.py", line 42, in
_NODE_MANAGER = _NodeManager()
File "/home/sapna/catapult/common/eslint/eslint/../../../common/node_runner/node_runner/node_util.py", line 26, in init
self.node_path = self.bm.FetchPath('node', self.os_name, self.arch_name)
File "/home/sapna/catapult/common/eslint/eslint/../../../common/py_utils/py_utils/binary_manager.py", line 38, in FetchPath
os_version)
File "/home/sapna/catapult/common/eslint/eslint/../../../common/py_utils/py_utils/binary_manager.py", line 60, in _WrapDependencyManagerFunction
return function(binary_name, platform)
File "/home/sapna/catapult/dependency_manager/dependency_manager/manager.py", line 130, in FetchPath
path, _ = self.FetchPathWithVersion(dependency, platform)
File "/home/sapna/catapult/dependency_manager/dependency_manager/manager.py", line 89, in FetchPathWithVersion
raise exceptions.NoPathFoundError(dependency, platform)
dependency_manager.exceptions.NoPathFoundError: No file could be found locally, and no file to download from cloud storage for node on platform linux_i686

sapna@sapna:/catapult$ git --version
git version 2.13.0
sapna@sapna:
/catapult$ python --version
Python 2.7.6

@anniesullie
Copy link
Contributor

I'm really sorry, it looks like you're using a 32 bit linux machine. We only support 64 bit. Can you try again from a 64 bit linux machine?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants