Change TargetFramework from netcoreapp2.0 to netstandard2.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robvanpamel The reason why Unit Tests can not pass is mainly caused by RSAEncryptionPadding.OaepSHA512 ! I have opened an issue in the original repo . By the way , I'm vary glad that you send this PR to me , but I am not the owner of this repo , I can't publish a new version Nuget package . Thanks !! |
|
I have merge this PR and create a new PR to the original repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we want to use this library in a .NET standard class library it needs to be a .NET standard library as well. I think it makes no sense to have it as a netcoreapp2.0 project as well.
Since we are running on Linux the unit-tests for RSA were not running before, nor after (since only OpenSSL is available) Can you verify these?