feat: dark and light theme support#442
Conversation
| darkFlavor = lib.mkOption { | ||
| type = catppuccinLib.types.flavor; | ||
| default = config.catppuccin.flavor; | ||
| description = "Global Catppuccin dark flavor"; | ||
| }; | ||
|
|
||
| lightFlavor = lib.mkOption { | ||
| type = catppuccinLib.types.flavor; | ||
| default = config.catppuccin.flavor; | ||
| description = "Global Catppuccin light flavor"; | ||
| }; |
There was a problem hiding this comment.
I'm not too big a fan of this API. I think it'd be better to have a single enum option defining whether or not to use dark mode, and continuing using the local flavor option in modules (which should be fine since both can still be overridden on a per-module basis if you'd like light mode with a different-than-global flavor for example)
i.e., this would become
{
# Or maybe name it `mode`? I dunno
theme = lib.mkOption {
type = lib.types.oneOf [ "light" "dark" ];
default = dark;
description = "Global Catppuccin theme type";
example = lib.literalExpression "light";
};
}There was a problem hiding this comment.
I see the idea, but i assume some people like macOS users would be more wanting to have the dark and light options since they are not enforced into declarative light/dark.
There was a problem hiding this comment.
Oh and totally forgot for ghostty which is a single string, making it a bit hard to do that.
There was a problem hiding this comment.
I'm not too sure how else to generalize this API then. Having dynamic light/dark is virtually exclusive to macOS, and most apps will just not support it; I don't know where else this would really be used besides Ghostty and Zed
If we can configure either of those two to use a "dynamic" mode, I would be fine with that being a third option in this enum -- and those two ports having their own exclusive light/darkFlavor options. Otherwise I don't think this is a good fit here
There was a problem hiding this comment.
Having dynamic light/dark is virtually exclusive to macOS
you can now have a light/dark switching on linux more modernly. so maybe we could achieve this now. and is becoming more common of a option like in fish. we also support nixos modules which are websites so they would naturally have light/dark toggles.
i think the enum isn't a great approach tho since it makes the api much more complex than it needs to be. and we would have to maybe introduce new options. for example the fish port supports dynamic theming but only with latte light mode. which compared to userstyles feels regressive.
If Firefox Userstyles gets merged, that'd be another - currently setting both light and dark to the same flavor |
This comment was marked as spam.
This comment was marked as spam.
|
This would be really neat for #549, since COSMIC has support for automatically switching themes when it's day or night |
This comment was marked as spam.
This comment was marked as spam.
88c9409 to
1299c61
Compare
1299c61 to
6f18993
Compare
Perhaps a oversight but a understandable one seeing as we currently only have 1 reactive theme, zed. But that may change with the addition of ghostty!
closes #420
The idea here was to introduce
darkFlavorandlightFlavorin a very none breaking way, such that they both default toconfig.catppuccin.flavorrather thenmochaandlatterespectively.