Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to scala 3 #532

Merged
merged 13 commits into from
Nov 28, 2024
Merged

feat: migrate to scala 3 #532

merged 13 commits into from
Nov 28, 2024

Conversation

ccantarero91
Copy link
Collaborator

@ccantarero91 ccantarero91 commented Nov 27, 2024 •
edited
Loading

First PR to change the Scala version to Scala 3.3.3 Changes:

  • Bumped the Scala version in the build.sbt and removed the kind-projector compiler plugin.
  • Removed one of the docs related to Sleep since it was not compiling, which is part of a previous change.
  • Applied all necessary syntax changes.
  • Simplified all braces to conform to Scala 3 standards.
  • Replaced all implicit keywords with given or using.
  • Changed sealed traits to Scala 3 enums
  • Added two TODOs for parts of the codebase still using implicits that need to be changed to extension methods over Action. These changes will be addressed in a following PR to unlock these updates

All the test and pipelines keep working after the changes.

@ccantarero91 ccantarero91 force-pushed the 526-finish-migrating-to-scala-3 branch from 8e336a2 to d30f739 Compare November 27, 2024 18:43
@ccantarero91 ccantarero91 marked this pull request as ready for review November 28, 2024 15:13
@cb372 cb372 merged commit 20f49f1 into v4 Nov 28, 2024
5 checks passed
@cb372 cb372 deleted the 526-finish-migrating-to-scala-3 branch November 28, 2024 16:08
@ccantarero91 ccantarero91 mentioned this pull request Dec 2, 2024
Merged
cb372 pushed a commit that referenced this pull request Dec 3, 2024
@ccantarero91 @AlejandroBudy
feat: migrate to scala 3 v2 (#538)
ab0134d 
This PR finish the scala 3 changes on
#532

---------

Co-authored-by: Cristian Cantarero <[email protected]>
Co-authored-by: alejandrobudy <[email protected]>
Co-authored-by: Alejandro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb372 cb372 cb372 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccantarero91 @cb372