Support holes as function arguments #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given `foo.bar(123, "abc", ???)`, we look up the `foo.bar` symbol to get the types of its parameters, which gives us the type of the hole. Note: there's a big assumption here that the number of params exactly matches the number of args, which is not true in the case of default args, varargs, etc. So this will not catch all cases, but it's a step in the right direction.
cb372
commented
Nov 28, 2020
| @@ -61,11 +61,25 @@ Relevant bindings include | |||
| val hole13: (Int, String) => (String, Int) = { (a, b) => ??? } | |||
| ^ | |||
| src/test/resources/val-var-def-one-liners/input.scala:31: | |||
| Found hole with type: Int | |||
| Found hole with type: B | |||
There was a problem hiding this comment.
I feel like if I can find the right incantation I can persuade the compiler to fill in this type param with the concrete type. More experimentation needed...
cb372
commented
Nov 28, 2020
| def hole15(x: String) = x.contains(???) | ||
| ^ | ||
| src/test/resources/val-var-def-one-liners/input.scala:35: | ||
| Found hole with type: A => Boolean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
foo.bar(123, "abc", ???), we look up thefoo.barsymbol to get the types of its parameters, which gives us the type of the hole.Note: there's a big assumption here that the number of params exactly matches the number of args, which is not true in the case of default args, varargs, etc. So this will not catch all cases, but it's a step in the right direction.
Fixes #43