Solves problems in "feat(pdf): add optional tile borders to PDF export (#1954)" PR#2079
Open
magush27 wants to merge 8 commits intocboard-org:masterfrom
Open
Solves problems in "feat(pdf): add optional tile borders to PDF export (#1954)" PR#2079magush27 wants to merge 8 commits intocboard-org:masterfrom
magush27 wants to merge 8 commits intocboard-org:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR repairs and completes the “optional tile borders in PDF export” feature by wiring the UI option through the export pipeline, adding i18n for the new label, and fixing related export/PDF rendering logic.
Changes:
- Add an “Show borders around tiles in PDF” checkbox and i18n message for it.
- Thread a
showTileBordersflag through the export container/helpers into PDF generation. - Adjust PDF tile rendering to apply per-tile borders when the flag is enabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/components/Settings/Export/Export.messages.js | Adds i18n string for the new PDF tile border option (plus minor formatting). |
| src/components/Settings/Export/Export.helpers.js | Adds showTileBorders plumbing and applies border/borderColor on generated PDF table cells. |
| src/components/Settings/Export/Export.container.js | Adds showTileBorders parameter to export handler and passes it into export helpers. |
| src/components/Settings/Export/Export.component.js | Adds the checkbox UI and state handling for the showTileBorders setting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues found in #1960 that prevented the tile borders feature from working correctly:
Things fixed
CHANGELOG.md- Removed the changelog entry as asked by one of the mantainers.Export.component.js- Fixed incorrect method name referenceExport.helpers.js- Removed broken code block, fixed parameter passing throughout the call chain and implemented actual border rendering logicExport.messages.js- Added proper internationalizationExport.component.js- Fixed UI layout overlapTesting
To test:
Fixes #1960