Skip to content

fix: replace return with continue in updateApiMarkedBoards loop#2131

Open
12somyasahu wants to merge 1 commit intocboard-org:masterfrom
12somyasahu:fix/update-api-marked-boards-early-exit
Open

fix: replace return with continue in updateApiMarkedBoards loop#2131
12somyasahu wants to merge 1 commit intocboard-org:masterfrom
12somyasahu:fix/update-api-marked-boards-early-exit

Conversation

@12somyasahu
Copy link

Closes #2130

Problem

In updateApiMarkedBoards (src/components/Board/Board.actions.js),
the guard inside the for await loop used return instead of continue:

if (!boardsIds.includes(board.id)) return;

This exits the entire async function when a board is missing from state,
silently abandoning all remaining boards that have markToUpdate: true.

Fix

Changed return to continue so the loop skips the removed board
and processes the remaining ones.

Changes

  • 1 line changed in src/components/Board/Board.actions.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

updateApiMarkedBoards exits early when a board is removed from state

1 participant