Merging release/4.3 to develop #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation in ExploreTest.java.
1. Added grant and revoke methods that uses sentry client to grant and revoke privileges on entities to users. 2. Modified tests in BasicAuthorizationTest to test authorization checks for the following entity types. - namespace - dataset - datasetType - streams - no more autogrants in cdap 3. Please use the new runtime option specified in README.
Modified integration tests to use the new authorization model
fix compiler error
Fix checkstyle.
anwar6953
commented
Aug 22, 2017
integration-test-remote/pom.xml
Outdated
| <dependencies> | ||
| <dependency> | ||
| <groupId>co.cask.cdap</groupId> | ||
| <artifactId>cdap-sentry-model</artifactId> | ||
| <version>0.6.0-SNAPSHOT</version> |
There was a problem hiding this comment.
what should be the version for these 3 dependencies on develop branch?
@rohitsinha54 @yaojiefeng @poornachandra
There was a problem hiding this comment.
I think we can keep it as 0.6.0-SNAPSHOT, this will get removed when we migrate our tests to use wildcard privileges
…htest-to-new-model Migrate old auth test to use the new auth model
Fix compilation.
Bump cdap dependency to 4.3.0
yaojiefeng
reviewed
Aug 28, 2017
integration-test-remote/pom.xml
Outdated
| <dependencies> | ||
| <dependency> | ||
| <groupId>co.cask.cdap</groupId> | ||
| <artifactId>cdap-sentry-model</artifactId> | ||
| <version>0.6.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Shall we update this to the latest version?
There was a problem hiding this comment.
To 0.6.0?
And then this'll get removed later right?
There was a problem hiding this comment.
Yeah, it should get removed once the I have refactored the latest integration pr.
|
Just one comment about the version, rest LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging release/4.3 to develop