[2.4] Feature/ui adhoc query #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/ui-adhoc_query
…iewing results for an an inactive or has_results=false query. Hide other queries' results when viewing another query's results. Display Query start time, rather than query handle. Update the list of queries based upon an interval (status, is_active, has_results attributes). Move navigational arrows up and to the left.
…depending on which page you are on).
…as expected with page-nav buttons, so leaving it commented for now.
…-side sorting of queries, that is handled completely on server side. Also, fix bug that occurred when a query's results had a null value in it.
-Moved query/results links to the left. -Removed tooltip from Results Link (when submitting a near query). -Instead, submitting a query takes you to results page. -Remove execute button from results page (undone for now). -Results and status columns collapsed and moved to the left of query.
| load: function () { | ||
| var self = this; | ||
| C.fetchQueries = function(a,b,c){ |
There was a problem hiding this comment.
why bind to a global variable?
There was a problem hiding this comment.
It was for debugging purposes, removed now.
| load: function () { | ||
| var self = this; | ||
| C.fetchQueries = function(a,b,c){ | ||
| self.fetchQueries(a,b,c); |
There was a problem hiding this comment.
a,b,c doesn't make sense you can pass arguments as is if you need variable length arguments or use an object.
self.fetchQueries(arguments)
self.fetchQueries({
foo: bar
})
There was a problem hiding this comment.
This was simply for debugging, removed now.
|
LGTM (for including in release), missing items listed as TODOs. |
gsps1
pushed a commit
that referenced
this pull request
Mar 15, 2018
moving docs from readmes into their own markdown files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements and bugfixes to adhoc query UI.