Skip to content

Add a base class for scorers#34

Open
EpsIotaPi wants to merge 3 commits into
cdimascio:masterfrom
EpsIotaPi:master
Open

Add a base class for scorers#34
EpsIotaPi wants to merge 3 commits into
cdimascio:masterfrom
EpsIotaPi:master

Conversation

@EpsIotaPi

Copy link
Copy Markdown
Contributor

I create a base class for scorers, and I think this change could simplified the scorers' structures

@cdimascio

Copy link
Copy Markdown
Owner

thanks @EpsIotaPi this looks great.
one call out score vs raw_score changes the public api, correct?
can we continue to call it score for backward compatibility

@EpsIotaPi

Copy link
Copy Markdown
Contributor Author

I change the raw_score to score in class Result. Hope this change could solve the backward compatibility problem ~

@cdimascio cdimascio left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. However, the fact that score is replaced with results makes this a breaking change.

All in all, this is ok. I'll do a new major version version.

The readme needs a refresh to reflect the new results API. Once the readme updates are in the PR, I'll get this merged

Thanks for you're work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants