-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend end-to-end test workflows #427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I have mostly minor comments
Codecov Report
Additional details and impacted files
@@ Coverage Diff @@
## main #427 +/- ##
=======================================
- Coverage 84.4% 83.9% -0.5%
=======================================
Files 27 27
Lines 4852 4852
Branches 4852 4852
=======================================
- Hits 4095 4069 -26
- Misses 556 582 +26
Partials 201 201
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This PR extends the current end-to-end tests to add some additional capabilities. See the workflow diagram for the full flow. The high-level steps for each end-to-end test are:
Notes for reviewers:
cdk synth
on them. The manual review is especially helpful for reviewing style, format, etc. of the generated code.simple::golang
produces code that has errors during cdk synth (expand to see errors)
config::golang
produces code that has errors during cdk synth (expand to see errors)
documentdb::golang
produces code that has errors during cdk synth (expand to see errors)
resource_w_json_type_properties::golang
produces code that has errors during cdk synth (expand to see errors)
config::java, resource_w_json_type_properties::java
These tests do not fail CDK synth, but CDK synth produces templates with a non-deterministic order. This makes the tests validation of the produced template fail. We need to make the validation mechanism for these tests more sophisticated so that it can recognize equivalent templates, even when the json objects and properties are not necessarily in the same order.
sam_nodejs_lambda and sam_nodejs_lambda_arr_transform
These are new tests since I've been finalizing this PR. They still need to be run with
cdk synth
to see if it works or not.Future improvements to the end-to-end tests
#506
#507
#508
#509
#510
#511
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.