Skip to content

CED-2237: remove root-only apt-get from password-hashing sample - #41

Merged
yashanand1910 merged 1 commit into
mainfrom
feat/unprivileged-tests
Jul 29, 2026
Merged

CED-2237: remove root-only apt-get from password-hashing sample#41
yashanand1910 merged 1 commit into
mainfrom
feat/unprivileged-tests

Conversation

@TusharMohapatra07

Copy link
Copy Markdown
Contributor

No description provided.

@TusharMohapatra07 TusharMohapatra07 changed the title remove apt-get and make the job long running remove apt-get Jul 24, 2026
@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the Slurm benchmark’s conditional system-package installation, leaving Python dependencies to be installed directly with pip.

Confidence Score: 5/5

The PR appears safe to merge with no concrete, changed-code-triggered defect identified.

The change removes node-level package installation while retaining pip dependency setup, and the repository does not establish a supported runtime where this causes dependency installation or benchmark execution to fail.

Important Files Changed

Filename Overview
slurm/cpu/password-hashing-benchmark.sbatch Removes the apt-get block for native build dependencies; no concrete failure is established because the target Slurm environment and wheel compatibility are unspecified.

Reviews (1): Last reviewed commit: "remove apt-get and make the job long run..." | Re-trigger Greptile

@TusharMohapatra07
TusharMohapatra07 marked this pull request as ready for review July 24, 2026 18:03
@TusharMohapatra07 TusharMohapatra07 changed the title remove apt-get CED-2237: remove root-only apt-get from password-hashing sample Jul 24, 2026
@linear-code

linear-code Bot commented Jul 24, 2026

Copy link
Copy Markdown

CED-2237

@yashanand1910
yashanand1910 merged commit e793f5f into main Jul 29, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants