Skip to content

Fix errors and add warnings with optical properties#2306

Merged
sethrj merged 12 commits intoceleritas-project:developfrom
sethrj:optical-fix
Mar 11, 2026
Merged

Fix errors and add warnings with optical properties#2306
sethrj merged 12 commits intoceleritas-project:developfrom
sethrj:optical-fix

Conversation

@sethrj
Copy link
Member

@sethrj sethrj commented Mar 10, 2026

Split from #2303

  • Add a warning when both RAYLEIGH (rayleigh scattering MFP) and COMPRESSIBILITY (alternative analytic MFP calculation) are present.
  • Adds missing data to the DUNE cryostat test including RINDEX to the glass.
  • Fix failure when an optical material doesn't have scintillation.
  • Activate mucf import which wasn't being tested.
  • Mark GPU generator tests as disabled when CUDA is turned off via the environment (CI)

@sethrj sethrj added bug Something isn't working physics Particles, processes, and stepping algorithms labels Mar 10, 2026
@sethrj sethrj removed the request for review from drbenmorgan March 10, 2026 18:38
@github-actions
Copy link

github-actions bot commented Mar 10, 2026

Test summary

 5 950 files   9 569 suites   21m 34s ⏱️
 2 210 tests  2 169 ✅  41 💤 0 ❌
32 866 runs  32 725 ✅ 141 💤 0 ❌

Results for commit 8a595b1.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.24%. Comparing base (cd0fd07) to head (8a595b1).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2306      +/-   ##
===========================================
+ Coverage    87.21%   87.24%   +0.03%     
===========================================
  Files         1357     1357              
  Lines        43253    43246       -7     
  Branches     13688    13189     -499     
===========================================
+ Hits         37723    37732       +9     
+ Misses        4492     4305     -187     
- Partials      1038     1209     +171     
Files with missing lines Coverage Δ
src/celeritas/ext/detail/GeantPhysicsLoader.cc 95.13% <100.00%> (+2.79%) ⬆️
...leritas/optical/gen/detail/MatScintSpecInserter.hh 81.08% <100.00%> (-16.88%) ⬇️
src/geocel/GeantGdmlLoader.cc 84.93% <100.00%> (+0.20%) ⬆️

... and 113 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sethrj sethrj merged commit d4ab396 into celeritas-project:develop Mar 11, 2026
77 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working physics Particles, processes, and stepping algorithms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants