Do not document explicitly deleted functions #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think the better approach for this would be either building them but marking them, or preventing them from from being added to records in the first place. (Rather than having IDs in the record that point at nothing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, explicitly-deleted member functions showed up as defined, which is obviously wrong. Since a) functions can also be deleted implicitly and b) I'm unsure what the documentation for a deleted function should look like, I've opted for not exporting them altogether.
This requires an additional check in
Indexer::updateRecordNames()to avoid default-constructing non-existing DB entries.