Fix routing for /new to prevent 404 errors #58
Conversation
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=80&v=4){kind=small}
…g issue where navigating directly to the /new URL resulted in a 404 error. This change ensures that the development server correctly handles client-side routing, serving the index.html for all paths and allowing React Router to manage the application's routes. An end-to-end test has been added to verify that navigating directly to /new successfully loads the welcome page.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
Adds a custom `404.html` to handle client-side routing on GitHub Pages. This page captures the intended path, stores it in `sessionStorage`, and redirects to the root. The `App.tsx` component is updated to check for this `redirectPath` on load and navigate to the correct client-side route, ensuring that direct navigation to sub-paths works as expected. An end-to-end test has been added to verify the new redirect logic, and the architectural documentation in `AGENTS.md` has been updated to reflect this change.
1 participant
This pull request fixes a bug where users would see a 404 error page when navigating directly to the
/newURL in their browser. The issue was caused by the"homepage"property inpackage.json, which has now been removed to allow the development server to correctly handle client-side routing.An additional end-to-end test has been added to
e2e/routing.spec.tsto verify that a direct navigation to/newsuccessfully loads the welcome page, preventing future regressions.PR created automatically by Jules for task 447809867750893413