Refactor STL Conversion to Use Batch Processing #69
Conversation
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=80&v=4){kind=small}
This commit refactors the STL conversion logic to prevent race conditions and improve performance. The previous implementation used a queue to process each STL file individually, which led to issues with stale results overwriting newer ones. The new implementation sends all JSCAD scripts to the `jscad.worker.ts` in a single batch, along with a `configVersion`. The worker processes the scripts sequentially and returns all the results at once. The `ConfigContext` then checks the `configVersion` to ensure that only the latest results are applied to the application state. The loading bar and download buttons now remain active until the entire batch of conversions is complete, providing a better user experience.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
This change refactors the STL conversion process to prevent race conditions by using a batch processing model with versioning. It updates the JSCAD worker to handle multiple scripts at once and modifies the
ConfigContextto manage the batch requests and responses, ensuring that only the latest results are applied to the application state. The loading indicators have also been updated to reflect the new conversion process.PR created automatically by Jules for task 4827732893959031537