[Feat] #208 - 애플 로그인 구현 및 소셜로그인 타입별 예상되는 사이드 이펙트 대응 #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sangyup12
reviewed
Feb 2, 2026
Contributor
sangyup12
left a comment
sangyup12
left a comment
There was a problem hiding this comment.
리브랜딩 이미지까지 ㄷㄷ. 진짜 얼마 안 남았다!! 저도 빠르게 마무리 해보겠습니다!
|
|
||
| import KakaoSDKUser | ||
| import KakaoSDKAuth | ||
| import AuthenticationServices |
| var temporarySignUpData: LoginResponseEntity? | ||
| var nickname: String = "" | ||
| var name: String = "" | ||
| var socialType: String = "" |
Contributor
There was a problem hiding this comment.
userId 추가해서 사용하도록 하겠습니다. 감사합니다
Comment on lines
153
to
162
| @@ -151,7 +159,7 @@ extension OnboardingViewModel { | |||
| jobs: selectedJobCategory | |||
| ) | |||
|
|
|||
| let result = await signupUseCase.execute(request: requestData, preSignUpToken: authManger.preSignupToken) | |||
| let result = await signupUseCase.execute(request: requestData, preSignUpToken: authManger.preSignupToken!) | |||
Contributor
There was a problem hiding this comment.
p2
엔티티와 토큰 강제 언래핑하는 거 크래쉬 위험 괜찮을까여?
Member
Author
There was a problem hiding this comment.
아뇨.. 사실 안 좋은데 로그인 시도 시에 유저 존재 여부에 따라 응답이 다르게 내려오고 있더라구요
그래서 하나의 요청에서 성공 시 응답이 두 개로 갈린 상황이라 dto에 nullable한 필드가 많이 생겼고, 이 dto를 사용하던 엔티티를 최대한 기존 코드 수정없이 바꾸려다가 그냥 강제 언래핑했어요...
좀 더 신경쓰면 엔티티를 나눈다던지.. 방법이 있긴 한데 최대한 기존 코드들 안 건드리려고 요렇게 함..
Yeonnies
approved these changes
Feb 9, 2026
| // | ||
|
|
||
| import SwiftUI | ||
| import Combine |
|
|
||
| actor TokenRefresher { | ||
| static let shared = TokenRefresher() | ||
| nonisolated let tokenExpiredSubject = PassthroughSubject<Void, Never>() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 작업한 브랜치
feat/#208✅ 작업한 내용
📟 관련 이슈