Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gltf-loader-ts is not a dev-dependency, but a dependency #260

Closed
anne-gropler opened this issue Jul 20, 2020 · 1 comment · Fixed by #261
Closed

gltf-loader-ts is not a dev-dependency, but a dependency #260

anne-gropler opened this issue Jul 20, 2020 · 1 comment · Fixed by #261
Labels
bug Something isn't working question Further information is requested

Comments

@anne-gropler
Copy link
Collaborator

anne-gropler commented Jul 20, 2020

I am not sure about how dev-dependencies are treated when webgl-operate is used as a library, but it seems that gltf-loader-ts is not a dev-dependency, but a real dependency. There are classes imported from it in file gltfloader.ts.

I use webgl-operate in a library A that is used in app B. When I compile library A (which has a direct dependency on webgl-operate), everything seems to be fine. However, when I compile and start the app B (depends on A, which depends on webgl-operate), then an Error is shown regarding gltf-loader-ts not being found.

It seems that declaring gltf-loader-ts as a dependency in package.json fixes this. But since I don't work with dependencies that much, there might be a better option?

@anne-gropler anne-gropler added bug Something isn't working question Further information is requested labels Jul 20, 2020
@anne-gropler
Copy link
Collaborator Author

@p-otto I saw that you worked on the gltf loader. Do you know more about this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant